linux-kernel - Re: [PATCH 46/58] x86: arch/x86/kernel/irqinit.c: Add prototype for init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121119170837.GA2882@jtriplet-mobl1>
Date:	Mon, 19 Nov 2012 09:08:37 -0800
From:	Josh Triplett <josh@...htriplett.org>
To:	David Howells <dhowells@...hat.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Kees Cook <keescook@...omium.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 46/58] x86: arch/x86/kernel/irqinit.c: Add prototype for
 init_IRQ

On Mon, Nov 19, 2012 at 10:36:17AM +0000, David Howells wrote:
> Josh Triplett <josh@...htriplett.org> wrote:
> > arch/x86/kernel/irqinit.c defines an __init function init_IRQ, called
> > from init/main.c.  No header file prototypes init_IRQ, because
> > init/main.c tends to directly define prototypes for init functions it
> > calls, rather than including appropriate headers.  So, add a prototype
> > of init_IRQ to arch/x86/kernel/irqinit.c right above the definition, to
> > satisfy gcc (-Wmissing-prototypes) and Sparse (-Wdecl).
> 
> Rather, you should put a declaration for it in a header file.

Happy to do so, except that as far as I can tell it doesn't seem
appropriate for any existing header, and creating a new header for the
sole purpose of that one prototype seems excessive, particularly since
the function only has the one call from init/main.c.  Nonetheless, if
you'd like a new header created for that prototype, or you have a
suggestion for an existing header I missed that seems appropriate, let
me know and I'll respin the patch.

- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/