linux-kernel - Re: [PATCH 2/2] drivres/power/jz4740-battery.c: Use devm_request_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 18 Nov 2012 16:12:05 -0800
From:	Anton Vorontsov <cbouatmailru@...il.com>
To:	Lars-Peter Clausen <lars@...afoo.de>
Cc:	Marcos Paulo de Souza <marcos.souza.org@...il.com>,
	dwmw2@...radead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] drivres/power/jz4740-battery.c: Use
 devm_request_and_ioremap

On Fri, Nov 09, 2012 at 10:42:11AM +0100, Lars-Peter Clausen wrote:
> On 11/07/2012 12:11 AM, Marcos Paulo de Souza wrote:
> > No functional changes. Just a cleanup.
> > 
> > Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@...il.com>
> 
> Looks good to me:
> 
> Acked-by: Lars-Peter Clausen <lars@...afoo.de>

Thanks for the patches and for the reviews!

> One minor comment though:
[...]
> devm_request_and_ioremap will print its own error messages if it fails, so
> strictly speaking this is not necessary, but I don't think it is worth doing
> resend just for this.

> Anton, maybe you can just remove the line when applying the patch.

Sure, I fixed it up and applied.

Anton.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/