linux-kernel - Re: [PATCH] backlight: 88pm860x_bl: remove an unnecessary line continuation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20121119142157.620fcfde.akpm@linux-foundation.org>
Date:	Mon, 19 Nov 2012 14:21:57 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Jingoo Han <jg1.han@...sung.com>
Cc:	"'LKML'" <linux-kernel@...r.kernel.org>,
	"'Richard Purdie'" <rpurdie@...ys.net>,
	"'Joe Perches'" <joe@...ches.com>
Subject: Re: [PATCH] backlight: 88pm860x_bl: remove an unnecessary line
 continuation

On Mon, 19 Nov 2012 10:38:53 +0900
Jingoo Han <jg1.han@...sung.com> wrote:

> This patch removes remove an unnecessary line continuation in
> pm860x_backlight_probe(). Also, a checkpatch warning is fixed
> as below:
> 
> WARNING: Avoid unnecessary line continuations
> 
> --- a/drivers/video/backlight/88pm860x_bl.c
> +++ b/drivers/video/backlight/88pm860x_bl.c
> @@ -228,7 +228,7 @@ static int pm860x_backlight_probe(struct platform_device *pdev)
>  	sprintf(name, "backlight-%d", pdev->id);
>  	data->port = pdev->id;
>  	data->chip = chip;
> -	data->i2c = (chip->id == CHIP_PM8606) ? chip->client	\
> +	data->i2c = (chip->id == CHIP_PM8606) ? chip->client
>  			: chip->companion;
>  	data->current_brightness = MAX_BRIGHTNESS;
>  	if (pm860x_backlight_dt_init(pdev, data, name)) {

It's still pretty ugly, but looky here:

diff -puN drivers/video/backlight/88pm860x_bl.c~backlight-88pm860x_bl-remove-an-unnecessary-line-continuation-fix drivers/video/backlight/88pm860x_bl.c
--- a/drivers/video/backlight/88pm860x_bl.c~backlight-88pm860x_bl-remove-an-unnecessary-line-continuation-fix
+++ a/drivers/video/backlight/88pm860x_bl.c
@@ -228,8 +228,7 @@ static int pm860x_backlight_probe(struct
 	sprintf(name, "backlight-%d", pdev->id);
 	data->port = pdev->id;
 	data->chip = chip;
-	data->i2c = (chip->id == CHIP_PM8606) ? chip->client
-			: chip->companion;
+	data->i2c = (chip->id == CHIP_PM8606) ? chip->client : chip->companion;
 	data->current_brightness = MAX_BRIGHTNESS;
 	if (pm860x_backlight_dt_init(pdev, data, name)) {
 		if (pdata) {
_

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/