linux-kernel - Re: [PATCH] regmap: introduce tables for readable/writeable/volatile/precious checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121120060509.GB10560@opensource.wolfsonmicro.com>
Date:	Tue, 20 Nov 2012 15:05:11 +0900
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Davide Ciminaghi <ciminaghi@...dd.com>
Cc:	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regmap: introduce tables for
 readable/writeable/volatile/precious checks

On Mon, Nov 19, 2012 at 02:31:53PM +0100, Davide Ciminaghi wrote:
> Many of the regmap enabled drivers implementing one or more of the
> readable, writeable, volatile and precious methods use the same code
> pattern:
> 
> 	return ((reg >= X && reg <= Y) || (reg >= W && reg <= Z) || ...)
> 
> Switch to a data driven approach, using tables to describe
> readable/writeable/volatile and precious registers ranges instead.
> The table based check can still be overridden by passing the usual function
> pointers via struct regmap_config.

Sorry, the code looks good but I just realised we already have a feature
called ranges - the paged window support also calls the regions it uses
ranges.  Can I suggest access_table or similar instead?  Sorry about
that - I should've realised.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)