linux-kernel - [PATCH] DMA interrupt mask value should not be hard coded

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1353393959.4445.82.camel@bichao>
Date:	Tue, 20 Nov 2012 14:45:59 +0800
From:	chao bi <chao.bi@...el.com>
To:	djbw@...com, vinod.koul@...el.com
Cc:	linux-kernel@...r.kernel.org, jun.d.chen@...el.com
Subject: [PATCH] DMA interrupt mask value should not be hard coded


In intel_mid_dma.c, when setup DMA controller, its interrupt
mask value is hard coded, it's not needed because this value
has already been initiated and set value according to DMA
channels which are used.

cc: Chen Jun <jun.d.chen@...el.com>
Signed-off-by: channing <chao.bi@...el.com>
---
 drivers/dma/intel_mid_dma.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/dma/intel_mid_dma.c b/drivers/dma/intel_mid_dma.c
index 02b21d7..11a1a48 100644
--- a/drivers/dma/intel_mid_dma.c
+++ b/drivers/dma/intel_mid_dma.c
@@ -1161,7 +1161,6 @@ static int mid_setup_dma(struct pci_dev *pdev)
 		if (0 != err)
 			goto err_irq;
 	} else {
-		dma->intr_mask = 0x03;
 		pr_debug("MDMA:Requesting irq for DMAC2\n");
 		err = request_irq(pdev->irq, intel_mid_dma_interrupt2,
 			IRQF_SHARED, "INTEL_MID_DMAC2", dma);
-- 
1.7.1



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/