linux-kernel - Re: [PATCH] Coccicheck: Improvement for online checking with 'make C=[12]'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <50AB5462.9030401@suse.cz>
Date:	Tue, 20 Nov 2012 10:58:58 +0100
From:	Michal Marek <mmarek@...e.cz>
To:	Nicolas Palix <nicolas.palix@...g.fr>
Cc:	Julia Lawall <Julia.Lawall@...6.fr>, linux-kernel@...r.kernel.org,
	cocci@...teme.lip6.fr
Subject: Re: [PATCH] Coccicheck: Improvement for online checking with 'make
 C=[12]'

Hi Nicolas,

sorry for the delay.

On 12.10.2012 10:48, Nicolas Palix wrote:
> +    # The ignore_unknown_options flag requires Coccinelle >= 0.2.3
> +    FLAGS="-ignore_unknown_options -very_quiet"
> +    if [ "$KBUILD_EXTMOD" = "" ] ; then
> +        OPTIONS="-dir $srctree $*"

Why is -Iinclude not needed in this case?


> +    else
> +        OPTIONS="-dir $KBUILD_EXTMOD -patch $srctree -I $srctree/include -I $KBUILD_EXTMOD/include $*"
> +    fi

The main Makefile exports the $LINUXINCLUDE variable, which contains all
the needed -I options. It would be cleaner to use that instead.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/