linux-kernel - Re: [PATCH] gpiolib: let gpiochip_add_pin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdbQAzv4c1d0hg1qwbr-h1nWzQBxC7k25Tn41sVSxeVBYQ@mail.gmail.com>
Date:	Tue, 20 Nov 2012 13:57:27 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Viresh Kumar <viresh.kumar@...aro.org>
Cc:	Linus Walleij <linus.walleij@...ricsson.com>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	Shiraz Hashim <shiraz.hashim@...com>,
	Stephen Warren <swarren@...dia.com>,
	Anmar Oueja <anmar.oueja@...aro.org>,
	Grant Likely <grant.likely@...retlab.ca>
Subject: Re: [PATCH] gpiolib: let gpiochip_add_pin_range() specify offset

On Tue, Nov 20, 2012 at 1:55 PM, Viresh Kumar <viresh.kumar@...aro.org> wrote:
> On 20 November 2012 17:15, Linus Walleij <linus.walleij@...ricsson.com> wrote:
>> From: Linus Walleij <linus.walleij@...aro.org>
>>
>> Like with commit 3c739ad0df5eb41cd7adad879eda6aa09879eb76
>> it is not always enough to specify all the pins of a gpio_chip
>> from offset zero to be added to a pin map range, since the
>> mapping from GPIO to pin controller may not be linear at all,
>> but need to be broken into a few consecutive sub-ranges or
>> 1-pin entries for complicated cases. The ranges may also be
>> sparse.
>>
>> This alters the signature of the function to accept offsets
>> into both the GPIO-chip local pinspace and the pin controller
>> local pinspace.
>>
>> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>
>
> Reviewed-by: Viresh Kumar <viresh.kumar@...aro.org>
>
> Aren't there any users of this routine?

No so I'm trying to use it right now and have to fix it up :-)

I just only got Shiraz to create it to handle non-DT devices...

Will spin a V2 by the way..

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/