linux-kernel - Re: [PATCH] Staging: rtl8187se: fixed some checkpatch warnings and errors in r8180

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121120142504.GC11248@mwanda>
Date:	Tue, 20 Nov 2012 17:25:04 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	MAACHE Mehdi <mehdi.maache@...il.com>
Cc:	greg@...ah.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, Tracey Dent <tdent48227@...il.com>
Subject: Re: [PATCH] Staging: rtl8187se: fixed some checkpatch warnings and
 errors in r8180_wx.c

On Tue, Nov 20, 2012 at 02:26:42PM +0100, MAACHE Mehdi wrote:
> This is a patch to the r8180_wx.c file that fixes up some warnings and errors found by the checkpatch.pl tool
> - WARNING: line over 80 characters
> - ERROR: "(foo*)" should be "(foo *)"
> - ERROR: "foo* bar" should be "foo *bar"
> - ERROR: trailing whitespace
> - ERROR: that open brace { should be on the previous line
>

This needs to be broken into 4-5 separate patches and sent as
series.  One patch per warning type.

> -	if (erq->flags & IW_ENCODE_DISABLED)
> -
> -	if (erq->length > 0) {
> -		u32* tkey = (u32*) key;
> +	if ((erq->flags & IW_ENCODE_DISABLED) && erq->length > 0) {
> +		u32 *tkey = (u32 *) key;

Interesting...  You have preserved the meaning of the original code,
but actually the original code is buggy.  Just delete the
"if (erq->flags & IW_ENCODE_DISABLED)" check.  This bug was
introduced in de171bd6ff "Staging: rtl8187se: r8180_wx: fixed a lot
of checkptahc.pl issues".

Send that as a separate patch and mark it as a bugfix.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/