linux-kernel - Re: [PATCH 1/3] perf session: Add perf_session__delete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121120151344.GA14928@infradead.org>
Date:	Tue, 20 Nov 2012 12:13:44 -0300
From:	Arnaldo Carvalho de Melo <acme@...hat.com>
To:	Feng Tang <feng.tang@...el.com>
Cc:	Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...e.hu>,
	Namhyung Kim <namhyung@...nel.org>,
	Andi Kleen <andi@...stfloor.org>, linux-kernel@...r.kernel.org,
	Namhyung Kim <namhyung.kim@....com>
Subject: Re: [PATCH 1/3] perf session: Add perf_session__delete_env

Em Tue, Nov 20, 2012 at 05:31:15PM +0800, Feng Tang escreveu:
> +static void perf_session__delete_env(struct perf_session *self)
> +{
> +	struct perf_session_env *env = &self->header.env;
> +
> +	free(env->hostname);
> +	free(env->os_release);
> +	free(env->version);
> +	free(env->arch);
> +	free(env->cpu_desc);
> +	free(env->cpuid);
> +
> +	free(env->cmdline);
> +	free(env->sibling_cores);
> +	free(env->sibling_threads);
> +	free(env->numa_nodes);
> +	free(env->pmu_mappings);
> +}

The object being deleted is a perf_session_env, so please make it
perf_session_env__delete(struct perf_session_env *env), and avoid using
'self'.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/