linux-kernel - Re: vt: regression caused by "Fix line garbage in virtual.."

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 20 Nov 2012 16:20:55 +0100
From:	Krzysztof Mazur <krzysiek@...lesie.net>
To:	Jean-Francois Moine <moinejf@...e.fr>
Cc:	Alan Cox <alan@...ux.intel.com>, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: vt: regression caused by "Fix line garbage in virtual.."

On Tue, Nov 20, 2012 at 09:54:21AM +0100, Jean-Francois Moine wrote:
> Thanks for testing. This time, the fix was easy.
> 
> But anyway, as it seems that my patch fixes only the Cubox machine and
> as we are still using a kernel 3.5 with specific patches, the fix may
> be delayed.
> 
> --->8 ---
> --- a/drivers/tty/vt/vt.c
> +++ b/drivers/tty/vt/vt.c
> @@ -539,25 +539,25 @@
>  {
>  	unsigned short *p = (unsigned short *) vc->vc_pos;
>  
> -	scr_memmovew(p + nr, p, vc->vc_cols - vc->vc_x);
> +	scr_memmovew(p + nr, p, (vc->vc_cols - vc->vc_x) * 2);
>  	scr_memsetw(p, vc->vc_video_erase_char, nr * 2);
>  	vc->vc_need_wrap = 0;
>  	if (DO_UPDATE(vc))
>  		do_update_region(vc, (unsigned long) p,
> -			(vc->vc_cols - vc->vc_x) / 2 + 1);
> +			vc->vc_cols - vc->vc_x);
>  }
>  
>  static void delete_char(struct vc_data *vc, unsigned int nr)
>  {
>  	unsigned short *p = (unsigned short *) vc->vc_pos;
>  
> -	scr_memcpyw(p, p + nr, vc->vc_cols - vc->vc_x - nr);
> +	scr_memcpyw(p, p + nr, (vc->vc_cols - vc->vc_x - nr) * 2);
>  	scr_memsetw(p + vc->vc_cols - vc->vc_x - nr, vc->vc_video_erase_char,
>  			nr * 2);
>  	vc->vc_need_wrap = 0;
>  	if (DO_UPDATE(vc))
>  		do_update_region(vc, (unsigned long) p,
> -			(vc->vc_cols - vc->vc_x) / 2);
> +			vc->vc_cols - vc->vc_x);
>  }
>  
>  static int softcursor_original;

Tested-by: Krzysztof Mazur <krzysiek@...lesie.net>

Thanks,

Krzysiek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/