linux-kernel - Re: [PATCH] [firmware_class] Fix compile with no builtin firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121120161011.GD18015@shaftnet.org>
Date:	Tue, 20 Nov 2012 11:10:11 -0500
From:	Solomon Peachy <pizza@...ftnet.org>
To:	Ming Lei <tom.leiming@...il.com>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] [firmware_class] Fix compile with no builtin firmware

On Wed, Nov 21, 2012 at 12:01:40AM +0800, Ming Lei wrote:
> > drivers/built-in.o: In function `release_firmware':
> > (.text+0x192e2): undefined reference to `__end_builtin_fw'
> > drivers/built-in.o: In function `release_firmware':
> > (.text+0x19304): undefined reference to `__end_builtin_fw'
> > drivers/built-in.o: In function `_request_firmware':
> > firmware_class.c:(.text+0x1986c): undefined reference to `__end_builtin_fw'
> > firmware_class.c:(.text+0x19886): undefined reference to `__end_builtin_fw'
> > firmware_class.c:(.text+0x19a98): undefined reference to `__end_builtin_fw'
> > drivers/built-in.o: In function `release_firmware':
> > (.text+0x192dc): undefined reference to `__start_builtin_fw'
> > drivers/built-in.o: In function `_request_firmware':
> > firmware_class.c:(.text+0x19860): undefined reference to `__start_builtin_fw'
> > firmware_class.c:(.text+0x19a8a): undefined reference to `__start_builtin_fw'
> 
> I have tried to reproduce the compile failure but not succeed, could you share
> your .config?

The corresponding .config is attached.  Note that it is for a uClinux 
3.3.0-uc0 kernel.

Even in the absence of the compile error, I believe the patch is correct.

 - Solomon
-- 
Solomon Peachy        		       pizza at shaftnet dot org	 
Melbourne, FL                          ^^ (mail/jabber/gtalk) ^^
Quidquid latine dictum sit, altum viditur.

View attachment ".config" of type "text/plain" (29740 bytes)

Content of type "application/pgp-signature" skipped