linux-kernel - Re: [patch] x86, UV: integer wrap bug in uv_hub_ipi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50ABB92D.5090401@zytor.com>
Date:	Tue, 20 Nov 2012 09:09:01 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Russ Anderson <rja@....com>
CC:	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Dan Carpenter <dan.carpenter@...cle.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Dimitri Sivanich <sivanich@....com>,
	Ingo Molnar <mingo@...hat.com>, x86@...nel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch] x86, UV: integer wrap bug in uv_hub_ipi_value()

On 11/20/2012 08:27 AM, Russ Anderson wrote:
>
> I very much agree.  I prefer u32, u64 (etc) because they are
> unambiguous.  It removes all doubt as to the actual meaning.
>
> Conversly, the fact that "long" has different meanings makes
> it at best problematic.  Was the code written assuming "long"
> was 32 or 64 bits?  Having data types that can have different
> sizes is just asking for trouble.
>

In the Linux kernel context, "long" effectively means the native size 
(size_t/intptr_t/ptrdiff_t).

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/