linux-kernel - Re: [PATCH 2/2] PM/devfreq: Fix return value in devfreq_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-id: <11617564.20991353493124275.JavaMail.weblogic@epml17>
Date:	Wed, 21 Nov 2012 10:18:44 +0000 (GMT)
From:	MyungJoo Ham <myungjoo.ham@...sung.com>
To:	Sachin Kamat <sachin.kamat@...aro.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc:	박경민 <kyungmin.park@...sung.com>,
	"patches@...aro.org" <patches@...aro.org>
Subject: Re: [PATCH 2/2] PM/devfreq: Fix return value in
 devfreq_remove_governor()

> Use the value obtained from the function instead of -EINVAL.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@...aro.org>

Acked-by: MyungJoo Ham <myungjoo.ham@...sung.com>

Both patches applied as they are obvious bugfixes.
I'll send pull request with other bugfixes within days.

> ---
>  drivers/devfreq/devfreq.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index 83c2129..2bd9ab0 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -644,7 +644,7 @@ int devfreq_remove_governor(struct devfreq_governor *governor)
>  	if (IS_ERR(g)) {
>  		pr_err("%s: governor %s not registered\n", __func__,
>  		       governor->name);
> -		err = -EINVAL;
> +		err = PTR_ERR(g);
>  		goto err_out;
>  	}
>  	list_for_each_entry(devfreq, &devfreq_list, node) {
> -- 
> 1.7.4.1
> 
> 
> 
> 
>        
>   
>          
>