linux-kernel - Re: [V2 PATCH 1/3] staging: ozwpan: Remove redundant null check before kfree in ozpd.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121121130527.GH11248@mwanda>
Date:	Wed, 21 Nov 2012 16:05:27 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Rupesh Gujare <rgujare@...odevices.com>
Cc:	devel@...verdev.osuosl.org, sachin.kamat@...aro.org,
	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org
Subject: Re: [V2 PATCH 1/3] staging: ozwpan: Remove redundant null check
 before kfree in ozpd.c

On Wed, Nov 21, 2012 at 12:46:15PM +0000, Rupesh Gujare wrote:
> Call kfree only if required else return from function.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@...aro.org>
> Signed-off-by: Rupesh Gujare <rgujare@...odevices.com>

I'm not sure this is right.

Signed-off-by is intended to have a legal meaning that you are
signing off that you have permission to submit the patch.  You're
not allowed to sign off on behalf of someone else.

If we apply this as is, then you get the author credit.  If you want
to give Sachin author credit then make the first line of the email:

From: Sachin Kamat <sachin.kamat@...aro.org>

Also it's not a good idea to get too control freaky over this code
which is all going to have to be replaced before this can graduate
out of staging.  You're just going to discourage people from
contributing if you redo all their patches.  Linaro people are the
real deal and you should let them help.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/