linux-kernel - Re: [PATCH] Staging: rtl8187se: bugfix in r8180

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121121134200.GH6186@mwanda>
Date:	Wed, 21 Nov 2012 16:42:00 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	MAACHE Mehdi <mehdi.maache@...il.com>
Cc:	greg@...ah.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, tdent48227@...il.com
Subject: Re: [PATCH] Staging: rtl8187se: bugfix in r8180_wx.c

On Wed, Nov 21, 2012 at 02:20:42PM +0100, MAACHE Mehdi wrote:
> This bug was introduced in de171bd6ff "Staging: rtl8187se: r8180_wx: fixed a lot of checkpatch.pl issues".
> 

The change log should describe the patch so we don't have to read
the code to know what it does.  Idealy it would describe the user
visible effects of the code, but neither you nor I really know what
those are.

Here is a better changelog.  Please resend with this or something
similar.

---
Subject: [PATCH v2] Staging: rtl8187se: remove check for IW_ENCODE_DISABLED

The original code had a no-op stub where it checked if
IW_ENCODE_DISABLED and did nothing.  Then in a cleanup patch we
accidentally turned the check on.  That was: de171bd6ff "Staging:
rtl8187se: r8180_wx: fixed a lot of checkpatch.pl issues".

The check should just be removed.
---

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/