linux-kernel - Re: [RFC/PATCH] mtd_blkdevs: Replace request handler kthread with a workqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1353510173.2701.7.camel@sauron.fi.intel.com>
Date:	Wed, 21 Nov 2012 17:02:53 +0200
From:	Artem Bityutskiy <dedekind1@...il.com>
To:	Ezequiel Garcia <elezegarcia@...il.com>
Cc:	linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org,
	David Woodhouse <dwmw2@...radead.org>
Subject: Re: [RFC/PATCH] mtd_blkdevs: Replace request handler kthread with a
 workqueue

On Sat, 2012-11-10 at 13:08 -0300, Ezequiel Garcia wrote:
> By replacing a kthread with a workqueue, the code is now a bit clearer.
> There's also a slight reduction of code size (numbers apply for x86):
> Before:
>    text	   data	    bss	    dec	    hex	filename
>    3248	     36	      0	   3284	    cd4	drivers/mtd/mtd_blkdevs.o
> 
> After:
>    text	   data	    bss	    dec	    hex	filename
>    3150	     36	      0	   3186	    c72	drivers/mtd/mtd_blkdevs.o
> 
> Due to lack of real hardware, tests have been performed on an emulated
> environment with mtdswap and mtdblock over nandsim devices.
> Some real testing should be done, before merging this patch.

Looks good to me, thanks, pushed to l2-mtd.git.

-- 
Best Regards,
Artem Bityutskiy

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)