linux-kernel - Re: [V2 PATCH 1/3] staging: ozwpan: Remove redundant null check before kfree in ozpd.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121121161859.GI6186@mwanda>
Date:	Wed, 21 Nov 2012 19:19:00 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Rupesh Gujare <rgujare@...odevices.com>
Cc:	devel@...verdev.osuosl.org, sachin.kamat@...aro.org,
	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org
Subject: Re: [V2 PATCH 1/3] staging: ozwpan: Remove redundant null check
 before kfree in ozpd.c

When someone sends a patch there are a several possible responses:
1) Ack the patch.
2) Request that the submitter redo it.  The downside is that no one
   likes redoing patches.
3) Reject the patch.
4) Redo it yourself and say "Based on a patch from Sachin Kamat".
   This isn't nice because everyone wants author credit.
5) Redo it and get permission from the original author to give them
   author credit get their signed-off-by.

Your version is better, that's not even a question.  It's just that
now we're in an awkward place and having long discussions about
trivial patches that are going to be re-written anyway.  :P

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/