linux-kernel - Re: [PATCH] mfd: lpc_ich: one uninitialized cell is no error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121121163501.GB18738@sortiz-mobl>
Date:	Wed, 21 Nov 2012 17:35:01 +0100
From:	Samuel Ortiz <sameo@...ux.intel.com>
To:	Paul Bolle <pebolle@...cali.nl>
Cc:	Peter Tyser <ptyser@...-inc.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: lpc_ich: one uninitialized cell is no error

Hi Paul,

On Mon, Nov 19, 2012 at 09:04:11PM +0100, Paul Bolle wrote:
> At every boot of an (outdated) laptop lpc_ich prints an error:
>     lpc_ich 0000:00:1f.0: I/O space for GPIO uninitialized
> 
> But if one looks at lpc_ich's probe function one notices that the code
> only cares if both lpc_ich_init_wdt() and lpc_ich_init_gpio() fail to
> add any cells. So stop treating the failure to add a single cell as an
> error. Those messages can be printed at notice level. And then only warn
> if no cells were added.
> 
> Signed-off-by: Paul Bolle <pebolle@...cali.nl>
> ---
> 0) This patch was written on top of v3.7-rc4 and tested on v3.6.7.
> 
> 1) Please note that this patch prints a warning when no MFD cells are
> added at all. I didn't make that an error because I'm not sure there's
> anything one can do if this happens. Is there?
> 
>  drivers/mfd/lpc_ich.c |   11 ++++++-----
>  1 files changed, 6 insertions(+), 5 deletions(-)
Applied, thanks.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/