linux-kernel - RE: [PATCH resend] TPM: Issue TPM_STARTUP at driver load if the TPM has not been started

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 21 Nov 2012 17:37:44 +0000
From:	<Peter.Huewe@...ineon.com>
To:	<jgunthorpe@...idianresearch.com>
CC:	<key@...ux.vnet.ibm.com>, <linux-kernel@...r.kernel.org>,
	<tpmdd-devel@...ts.sourceforge.net>
Subject: RE: [PATCH resend] TPM: Issue TPM_STARTUP at driver load if the TPM
 has not been started

Hi Jason,

>Great, I'll send an updated version, thanks!
;) You're welcome.

>> >+struct tpm_startup_in {
>> >+	__be16	startup_type;
>> >+} __packed;
>> 
>> 
>> All the other user
>> __attribute__((packed));
>> Care to change to be consistent?

> I used to __packed to avoid a checkpatch warning, they should probably
> all be changed?

Oh you're right - then sorry about my complaint.
Then I'd prefer submitting it as __packed and write another patch which change the remaining ones.
Are you creating the patch to change or should I?

Peter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/