linux-kernel - Re: [Pv-drivers] [PATCH 01/12] VMCI: context implementation.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 21 Nov 2012 13:10:18 -0800 (PST)
From:	Andy King <acking@...are.com>
To:	Joe Perches <joe@...ches.com>
Cc:	pv-drivers@...are.com, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org,
	virtualization@...ts.linux-foundation.org,
	George Zhang <georgezhang@...are.com>
Subject: Re: [Pv-drivers] [PATCH 01/12] VMCI: context implementation.

Hi Joe,

> Just some trivial notes.

Thanks for taking a look!

> > +		pr_warn("Failed to allocate memory for VMCI context.\n");
> 
> OOM logging messages aren't necessary as alloc failures
> are already logged with a stack trace.

Noted, we'll remove all such occurrences.

> Maybe just use
> 	struct vmci_event_msg e_msg;
> 	struct vmci_event_payld_ctx ev_payload;
> and change the addressing or use a cast as appropriate?

It does seem inelegant, we'll take a look.

> You also have some inconsistency in whether or not your
> logging messages use a terminating period.  I suggest
> you just delete all the periods.
> 	s/\.\\n"/\\n"/g

Gah, that's ugly.  We'll remove all of them as you suggest.

Thanks!
- Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/