linux-kernel - Re: [PATCH 1/2] mfd: add an AS3711 PMIC MFD driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121122011835.GD4371@opensource.wolfsonmicro.com>
Date:	Thu, 22 Nov 2012 10:18:37 +0900
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Guennadi Liakhovetski <g.liakhovetski@....de>
Cc:	linux-sh@...r.kernel.org, Magnus Damm <magnus.damm@...il.com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] mfd: add an AS3711 PMIC MFD driver

On Wed, Nov 21, 2012 at 07:21:02PM +0100, Guennadi Liakhovetski wrote:

> +	regmap_read(as3711->regmap, AS3711_ASIC_ID_1, &id1);
> +	regmap_read(as3711->regmap, AS3711_ASIC_ID_2, &id2);
> +	dev_info(as3711->dev, "AS3711 detected: %x:%x\n", id1, id2);
> +	if (id1 != 0x8b)
> +		return -ENODEV;

This looks odd - you're printing the "AS3711 detected" message prior to
checking the device ID which will be a bit confusing if there's a
problem.  Should probably do this after the ID check (and ideally also
check the return value of regmap_read(), it's especially important
during device identification where someone might've typoed the address).

Otherwise this looks good.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)