| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-id: <1353570264-18990-1-git-send-email-y@samsung.com> Date: Thu, 22 Nov 2012 16:44:24 +0900 From: y@...sung.com To: anton.vorontsov@...aro.org Cc: myungjoo.ham@...sung.com, kyungmin.park@...sung.com, linux-kernel@...r.kernel.org, Chanwoo Choi <cw00.choi@...sung.com> Subject: [PATCH 2/3] charger-manager: Fix bug when check dropped voltage after fullbatt event From: Chanwoo Choi <cw00.choi@...sung.com> This patch check difference value between current voltage of battery and desc->fullbatt_uV whether positve or negative number. If difference value is negative number when current voltage of battery is larger than desc->fullbatt_uV, charger-manager return immediately because battery is fully charged. Signed-off-by: Chanwoo Choi <cw00.choi@...sung.com> Signed-off-by: Myungjoo Ham <myungjoo.ham@...sung.com> Signed-off-by: Kyungmin Park <kyungmin.park@...sung.com> --- drivers/power/charger-manager.c | 9 ++++++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/power/charger-manager.c b/drivers/power/charger-manager.c index ee039b9..17130c7 100644 --- a/drivers/power/charger-manager.c +++ b/drivers/power/charger-manager.c @@ -468,7 +468,9 @@ static void fullbatt_vchk(struct work_struct *work) struct charger_manager *cm = container_of(dwork, struct charger_manager, fullbatt_vchk_work); struct charger_desc *desc = cm->desc; - int batt_uV, err, diff; + int batt_uV; + int err; + int diff; /* remove the appointment for fullbatt_vchk */ cm->fullbatt_vchk_jiffies_at = 0; @@ -482,8 +484,9 @@ static void fullbatt_vchk(struct work_struct *work) return; } - diff = desc->fullbatt_uV; - diff -= batt_uV; + diff = desc->fullbatt_uV - batt_uV; + if (diff < 0) + return; dev_info(cm->dev, "VBATT dropped %duV after full-batt.\n", diff); -- 1.7.0.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists