[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAJSP0QUai4O12U7fbrARAZLOig5=10e1WYg7i+OZTDETuDRWoQ@mail.gmail.com>
Date: Thu, 22 Nov 2012 21:08:55 +0100
From: Stefan Hajnoczi <stefanha@...il.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: devel@...verdev.osuosl.org, Markus Grabner <grabner@....tugraz.at>,
"line6linux-devel@...ts.sourceforge.net"
<line6linux-devel@...ts.sourceforge.net>,
linux-kernel <linux-kernel@...r.kernel.org>,
Laurent Navet <laurent_navet@...oo.com>
Subject: Re: [PATCH 00/46] staging: line6: drop MIDI state sysfs attrs
On Thu, Nov 22, 2012 at 8:58 PM, Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
> On Thu, Nov 22, 2012 at 08:48:39PM +0100, Stefan Hajnoczi wrote:
>> Markus and I have discussed the MIDI processing that currently happens in the
>> line6 driver. This stuff really belongs in userspace where a library or
>> utility can use ALSA MIDI APIs to control the device. Moving MIDI processing
>> to userspace has several benefits:
>>
>> 1. The driver only handles PCM and MIDI I/O. This means less kernel code.
>>
>> 2. A large number of sysfs attributes can be removed. These attributes exposed
>> MIDI state and driver code was necessary to sync and manage this state.
>>
>> 3. It's easier for userspace to control the device, try out new MIDI commands,
>> etc when the driver acts as a dumb transport.
>>
>> This patch series removes the sysfs attributes and then removes the state
>> behind those attributes. I have tried to make small incremental changes that
>> can be reviewed easily.
>
> Very nice, I'll queue these up on Monday, very good work, thanks so much
> for doing this.
Thanks! I hope Markus has a chance to review and/or test these
changes first - he knows generally what I'm up too but should have the
final word on details.
Stefan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists