lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 22 Nov 2012 20:48:47 +0100 From: Stefan Hajnoczi <stefanha@...il.com> To: devel@...verdev.osuosl.org Cc: Markus Grabner <grabner@....tugraz.at>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, line6linux-devel@...ts.sourceforge.net, <linux-kernel@...r.kernel.org>, laurent_navet@...oo.com, Stefan Hajnoczi <stefanha@...il.com> Subject: [PATCH 08/46] staging: line6: change monitor_level type ValueWait -> int The monitor_level sysfs attr has been dropped and we never need to wait on the monitor_level value to change. Switch to a plain int and drop the wait queue. Signed-off-by: Stefan Hajnoczi <stefanha@...il.com> --- drivers/staging/line6/pod.c | 10 +++++----- drivers/staging/line6/pod.h | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c index 5a941fa..165c7ad 100644 --- a/drivers/staging/line6/pod.c +++ b/drivers/staging/line6/pod.c @@ -245,7 +245,7 @@ void line6_pod_process_message(struct usb_line6_pod *pod) switch (buf[6]) { case POD_monitor_level: - pod->monitor_level.value = value; + pod->monitor_level = value; break; PROCESS_SYSTEM_PARAM(routing); @@ -908,7 +908,7 @@ static int snd_pod_control_monitor_get(struct snd_kcontrol *kcontrol, { struct snd_line6_pcm *line6pcm = snd_kcontrol_chip(kcontrol); struct usb_line6_pod *pod = (struct usb_line6_pod *)line6pcm->line6; - ucontrol->value.integer.value[0] = pod->monitor_level.value; + ucontrol->value.integer.value[0] = pod->monitor_level; return 0; } @@ -919,10 +919,10 @@ static int snd_pod_control_monitor_put(struct snd_kcontrol *kcontrol, struct snd_line6_pcm *line6pcm = snd_kcontrol_chip(kcontrol); struct usb_line6_pod *pod = (struct usb_line6_pod *)line6pcm->line6; - if (ucontrol->value.integer.value[0] == pod->monitor_level.value) + if (ucontrol->value.integer.value[0] == pod->monitor_level) return 0; - pod->monitor_level.value = ucontrol->value.integer.value[0]; + pod->monitor_level = ucontrol->value.integer.value[0]; pod_set_system_param_int(pod, ucontrol->value.integer.value[0], POD_monitor_level); return 1; @@ -1053,7 +1053,7 @@ static int pod_try_init(struct usb_interface *interface, */ if (pod->line6.properties->capabilities & LINE6_BIT_CONTROL) { - pod->monitor_level.value = POD_system_invalid; + pod->monitor_level = POD_system_invalid; /* initiate startup procedure: */ pod_startup1(pod); diff --git a/drivers/staging/line6/pod.h b/drivers/staging/line6/pod.h index b3bf243..d5bbd2f 100644 --- a/drivers/staging/line6/pod.h +++ b/drivers/staging/line6/pod.h @@ -121,7 +121,7 @@ struct usb_line6_pod { /** Instrument monitor level. */ - struct ValueWait monitor_level; + int monitor_level; /** Audio routing mode. -- 1.8.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists