linux-kernel - Re: [POC] recoverable fault injection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 22 Nov 2012 14:41:08 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	Akinobu Mita <akinobu.mita@...il.com>
Cc:	linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org
Subject: Re: [POC] recoverable fault injection

On Thu, 2012-11-22 at 22:29 +0900, Akinobu Mita wrote:

> > As you can see in my macro, it's also possible for an allocation to fail
> > but the function to succeed, so the function that is called must have a
> > return value indicating success or failure. I ran into this with debug
> > objects, their allocation failed all the time but obviously the function
> > succeeded as debug objects fail gracefully if they can't allocate
> > memory.
> 
> Oh, I completely missed retrying part in your macro.
> 
> I looked into FAULT_INJECT_CALL_RECOVERABLE_FUNCTION again,
> then I realized that it is not necessary to be variadic macro.
> 
> You can define macro like wait_event() family and use it like below:
> 
>         return FAULT_INJECT_CALL_RECOVERABLE_FUNCTION(
>                 BIT(FAULT_ATTR_SLAB) | BIT(FAULT_ATTR_PAGE_ALLOC),
>                 _nl80211_remain_on_channel(skb, info));

Oh, right, good point. Maybe even pass the entire line, and the
evaluation of whether the function failed. Then we don't have to have
the assumption of it returning an int with the 0/-ERR behaviour:

int ret;

FAULT_INJECT_CALL_RECOVERABLE_FUNCTION(
	BIT(FAULT_ATTR_SLAB) | BIT(FAULT_ATTR_PAGE_ALLOC),
	ret = _nl80211_remain_on_channel(skb, info),
	ret != 0);

return ret;


Ok that's kinda ugly too ... hmm.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/