linux-kernel - Re: [BUGFIX PATCH] USB: chipidea: fix use after free bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87vccy3s02.fsf@ashishki-desk.ger.corp.intel.com>
Date:	Thu, 22 Nov 2012 11:29:33 +0200
From:	Alexander Shishkin <alexander.shishkin@...ux.intel.com>
To:	Lothar Waßmann <LW@...O-electronics.de>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	Lothar Waßmann <LW@...O-electronics.de>
Subject: Re: [BUGFIX PATCH] USB: chipidea: fix use after free bug

Lothar Waßmann <LW@...O-electronics.de> writes:

> The pointer to a platform_device struct must not be dereferenced after
> the device has been unregistered.
>
> This bug produces a crash when unloading the ci13xxx kernel module
> compiled with CONFIG_PAGE_POISONING enabled.
>
> Signed-off-by: Lothar Waßmann <LW@...O-electronics.de>

Good one, thanks.

Acked-by: Alexander Shishkin <alexander.shishkin@...ux.intel.com>

Greg, this is -stable material, applicable starting from v3.6.

> ---
>  drivers/usb/chipidea/core.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
> index f69d029..b726c49 100644
> --- a/drivers/usb/chipidea/core.c
> +++ b/drivers/usb/chipidea/core.c
> @@ -385,8 +385,9 @@ EXPORT_SYMBOL_GPL(ci13xxx_add_device);
>  
>  void ci13xxx_remove_device(struct platform_device *pdev)
>  {
> +	int id = pdev->id;
>  	platform_device_unregister(pdev);
> -	ida_simple_remove(&ci_ida, pdev->id);
> +	ida_simple_remove(&ci_ida, id);
>  }
>  EXPORT_SYMBOL_GPL(ci13xxx_remove_device);
>  
> -- 
> 1.7.2.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/