lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 22 Nov 2012 09:30:33 +0000 From: Russell King - ARM Linux <linux@....linux.org.uk> To: Dmitry Torokhov <dmitry.torokhov@...il.com> Cc: Mike Turquette <mturquette@...com>, Viresh Kumar <viresh.kumar@...aro.org>, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/3] CLK: uninline clk_prepare() and clk_unprepare() On Wed, Nov 21, 2012 at 06:17:50PM -0800, Dmitry Torokhov wrote: > > You've checked non-ARM architectures too? > > Yes: > > [dtor@...r-d630 linux-next]$ grep -r HAVE_CLK_PREPARE . > ./arch/arm/Kconfig: select HAVE_CLK_PREPARE > Binary file ./.git/objects/pack/pack-7dad5ee164f601f1327dc78648fa317772c2d872.pack matches > ./include/linux/clk.h:#ifdef CONFIG_HAVE_CLK_PREPARE > ./include/linux/clk.h:#ifdef CONFIG_HAVE_CLK_PREPARE > ./drivers/clk/Kconfig:config HAVE_CLK_PREPARE > ./drivers/clk/Kconfig: select HAVE_CLK_PREPARE Err, no you haven't, not with that grep. What you've found are the places which enable this, and say "yes, I have clk_prepare". What HAVE_CLK_PREPARE is about though is providing a transition path between drivers using clk_prepare() to platforms which _don't_ have a clk_prepare() implementation - and when it's unset, it provides a default implementation. So, finding all those places where the symbol exists is the exact opposite of what you need to be doing. You need to find those platforms which have CLK support, but which don't have HAVE_CLK_PREPARE selected. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists