lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAN1soZy+JCfsroyUBFe9M_MW-sakcWwuqQMT5h0=+Haq+SJ5fw@mail.gmail.com>
Date:	Fri, 23 Nov 2012 16:45:08 +0800
From:	Haojian Zhuang <haojian.zhuang@...il.com>
To:	Qing Xu <qingx@...vell.com>
Cc:	Linux Russell <linux@....linux.org.uk>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Grant Likely <grant.likely@...retlab.ca>,
	Rob Herring <rob.herring@...xeda.com>, cxie4@...vell.com,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	devicetree-discuss@...ts.ozlabs.org
Subject: Re: [PATCH 7/7] mfd: max8925: add dts

On Tue, Nov 6, 2012 at 3:49 PM, Qing Xu <qingx@...vell.com> wrote:
> From: Qing Xu <qingx@...vell.com>
>
> add max8925 dts support into mmp2 brownstone platform
>
> Signed-off-by: Qing Xu <qingx@...vell.com>
> ---
>  arch/arm/boot/dts/mmp2-brownstone.dts |  166 +++++++++++++++++++++++++++++++++
>  arch/arm/boot/dts/mmp2.dtsi           |    4 +-
>  2 files changed, 169 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/boot/dts/mmp2-brownstone.dts b/arch/arm/boot/dts/mmp2-brownstone.dts
> index c9b4f27..e22f58c 100644
> --- a/arch/arm/boot/dts/mmp2-brownstone.dts
> +++ b/arch/arm/boot/dts/mmp2-brownstone.dts
> @@ -29,6 +29,172 @@
>                         };
>                         twsi1: i2c@...11000 {
>                                 status = "okay";
> +                               pmic: max8925@3c {
> +                                       compatible = "marvell,max8925";
> +                                       reg = <0x3c>;
> +                                       interrupts = <1 0>;
> +                                       interrupt-parent = <&intcmux4>;
> +                                       interrupt-controller;
> +                                       #interrupt-cells = <1>;
> +
> +                                       regulators {
> +                                               SDV1 {
> +                                                       regulator-min-microvolt = <637500>;
> +                                                       regulator-max-microvolt = <1425000>;
> +                                                       regulator-boot-on;
> +                                                       regulator-always-on;
> +                                               };
> +                                               SDV2 {
> +                                                       regulator-min-microvolt = <650000>;
> +                                                       regulator-max-microvolt = <2225000>;
> +                                                       regulator-boot-on;
> +                                                       regulator-always-on;
> +                                               };
> +                                       };
> +                                       backlight {
> +                                               dual-string = <0>;
> +                                       };
> +                                       charger {
> +                                               batt-detect = <0>;
> +                                               topoff-threshold = <1>;
> +                                               fast-charge = <7>;
> +                                               no-temp-support = <0>;
> +                                               no-insert-detect = <0>;
> +                                       };
> +                                       rtc {
> +
> +                                       };
> +                                       onkey {
> +
> +                                       };
> +                                       touch {
> +
> +                                       };

Please remove these empty entries. Those mfd client drivers didn't parse any
property from DTS file.

> +                               };
>                         };
>                         rtc: rtc@...10000 {
>                                 status = "okay";
> diff --git a/arch/arm/boot/dts/mmp2.dtsi b/arch/arm/boot/dts/mmp2.dtsi
> index 80f74e2..2165a17 100644
> --- a/arch/arm/boot/dts/mmp2.dtsi
> +++ b/arch/arm/boot/dts/mmp2.dtsi
> @@ -41,7 +41,7 @@
>                                 mrvl,intc-nr-irqs = <64>;
>                         };
>
> -                       intcmux4@...82150 {
> +                       intcmux4: intcmux4@...82150 {
>                                 compatible = "mrvl,mmp2-mux-intc";
>                                 interrupts = <4>;
>                                 interrupt-controller;
> @@ -196,6 +196,8 @@
>                                 compatible = "mrvl,mmp-twsi";
>                                 reg = <0xd4011000 0x1000>;
>                                 interrupts = <7>;
> +                               #address-cells = <1>;
> +                               #size-cells = <0>;
>                                 mrvl,i2c-fast-mode;
>                                 status = "disabled";
>                         };
> --
> 1.7.0.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ