linux-kernel - Re: [PATCH] mfd: ab8500: add static linkage for battery info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121123094800.GH17471@gmail.com>
Date:	Fri, 23 Nov 2012 09:48:00 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	"Rajanikanth H.V" <rajanikanth.hv@...ricsson.com>
Cc:	anton.vorontsov@...aro.org, rob.herring@...xeda.com,
	robherring2@...il.com, francescolavra.fl@...il.com, arnd@...db.de,
	linus.walleij@...ricsson.com, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, linaro-dev@...ts.linaro.org,
	patches@...aro.org, STEricsson_nomadik_linux@...t.st.com,
	"Rajanikanth H.V" <rajanikanth.hv@...aro.org>
Subject: Re: [PATCH] mfd: ab8500: add static linkage for battery info

How do you want this patch to be treated?

> From: "Rajanikanth H.V" <rajanikanth.hv@...aro.org>
> 
> enforce static linkage for battery attributes structures
> 
> this patch is against: "mfd-ab8500-add-devicetree-support-for-fuelgauge"

Is this a patch or a branch? If it's a branch, why are you referencing
it? Have you issued a pull request? If it's a patch (I'm assuming it
hasn't been accepted yet), then you should just fix it up into the
patch.

> Signed-off-by: Rajanikanth H.V <rajanikanth.hv@...aro.org>
> ---
>  drivers/power/ab8500_bmdata.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/power/ab8500_bmdata.c b/drivers/power/ab8500_bmdata.c
> index ff8f055..db17930 100644
> --- a/drivers/power/ab8500_bmdata.c
> +++ b/drivers/power/ab8500_bmdata.c
> @@ -143,7 +143,7 @@ static struct abx500_res_to_temp temp_tbl[] = {
>   * Note that the batres_vs_temp table must be strictly sorted by falling
>   * temperature values to work.
>   */
> -struct batres_vs_temp temp_to_batres_tbl_thermistor[] = {
> +static struct batres_vs_temp temp_to_batres_tbl_thermistor[] = {
>  	{ 40, 120},
>  	{ 30, 135},
>  	{ 20, 165},
> @@ -157,7 +157,7 @@ struct batres_vs_temp temp_to_batres_tbl_thermistor[] = {
>   * Note that the batres_vs_temp table must be strictly sorted by falling
>   * temperature values to work.
>   */
> -struct batres_vs_temp temp_to_batres_tbl_ext_thermistor[] = {
> +static struct batres_vs_temp temp_to_batres_tbl_ext_thermistor[] = {
>  	{ 60, 300},
>  	{ 30, 300},
>  	{ 20, 300},
> @@ -168,7 +168,7 @@ struct batres_vs_temp temp_to_batres_tbl_ext_thermistor[] = {
>  };
>  
>  /* battery resistance table for LI ION 9100 battery */
> -struct batres_vs_temp temp_to_batres_tbl_9100[] = {
> +static struct batres_vs_temp temp_to_batres_tbl_9100[] = {
>  	{ 60, 180},
>  	{ 30, 180},
>  	{ 20, 180},
> -- 
> 1.7.10.4
> 

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/