[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20655.20022.819710.39381@ipc1.ka-ro>
Date: Fri, 23 Nov 2012 11:21:42 +0100
From: Lothar Waßmann <LW@...O-electronics.de>
To: Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc: alsa-devel@...a-project.org, Shawn Guo <shawn.guo@...aro.org>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ASoC: fsl: fix miscompilation of snd-soc-imx-pcm
Hi,
Mark Brown writes:
> On Fri, Nov 23, 2012 at 10:12:13AM +0100, Lothar Waßmann wrote:
> > Due to a broken make rule, sound/soc/fsl/imx-pcm-dma.c or
> > sound/soc/fsl/imx-pcm-fiq.c (whatever is selected via Kconfig) will
> > not be compiled into imx-pcm.o when building as module, i.e.:
>
> What I've been trying to do is get you to tell me what the problem is
> with the Makefile rule, it's really not clear to me what the issue is or
> why your change is better. I can see the practical results but nothing
> about how they came to be which makes it very hard to tell if this is a
> good fix.
>
I already included the actual error messages I got when loading the
sound module.
I also mentioned, that in case of module build some source files
aren't being compiled with those rules. What else do you expect?
Lothar Waßmann
--
___________________________________________________________
Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Geschäftsführer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996
www.karo-electronics.de | info@...o-electronics.de
___________________________________________________________
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists