linux-kernel - Re: [PATCH] gpio: stmpe: Add DT support for stmpe gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121123104140.GP17471@gmail.com>
Date:	Fri, 23 Nov 2012 10:41:40 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Viresh Kumar <viresh.kumar@...aro.org>
Cc:	linus.walleij@...aro.org, grant.likely@...retlab.ca,
	devicetree-discuss@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
	spear-devel@...t.st.com,
	Vipul Kumar Samar <vipulkumar.samar@...com>
Subject: Re: [PATCH] gpio: stmpe: Add DT support for stmpe gpio

> >  static struct mfd_cell stmpe_gpio_cell = {
> >  	.name		= "stmpe-gpio",
> > +	.of_compatible	= "st,stmpe-gpio",
> 
> There's no need for any of the STMPE to have their own compatible
> string, as they are MFD devices. They are registered as platform
> devices from the MFD subsystem.

Whoops, I've written this in the wrong place. 

Sorry, for the confusion. It does need to be here.

> >  	.resources	= stmpe_gpio_resources,
> >  	.num_resources	= ARRAY_SIZE(stmpe_gpio_resources),
> >  };
> >  
> >  static struct mfd_cell stmpe_gpio_cell_noirq = {
> >  	.name		= "stmpe-gpio",
> > +	.of_compatible	= "st,stmpe-gpio",

... and here.

> > +++ b/Documentation/devicetree/bindings/gpio/gpio-stmpe.txt
> > @@ -0,0 +1,18 @@
> > +STMPE gpio
> > +----------
> > +
> > +Required properties:
> > + - compatible: "st,stmpe-gpio"

... but this is wrong.

> > +Example:
> > +	stmpe_gpio {
> > +		compatible = "st,stmpe-gpio";
> > +		st,norequest-mask = <0x20>;	//gpio 5 can't be used
> > +	};

As is the example.

So will be the the DT - if you've already written it.

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/