linux-kernel - Re: [PATCH v4 05/11] pwm: pwm-tiecap: pinctrl support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87mwy8eb7w.fsf@dell.be.48ers.dk>
Date:	Fri, 23 Nov 2012 13:48:51 +0100
From:	Peter Korsgaard <jacmet@...site.dk>
To:	Thierry Reding <thierry.reding@...onic-design.de>
Cc:	"Philip\, Avinash" <avinashphilip@...com>,
	"paul\@pwsan.com" <paul@...an.com>,
	"tony\@atomide.com" <tony@...mide.com>,
	"linux\@arm.linux.org.uk" <linux@....linux.org.uk>,
	"Cousson\, Benoit" <b-cousson@...com>,
	"Hiremath\, Vaibhav" <hvaibhav@...com>,
	"AnilKumar\, Chimata" <anilkumar@...com>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree-discuss\@lists.ozlabs.org" 
	<devicetree-discuss@...ts.ozlabs.org>,
	"linux-doc\@vger.kernel.org" <linux-doc@...r.kernel.org>,
	"linux-omap\@vger.kernel.org" <linux-omap@...r.kernel.org>,
	"linux-arm-kernel\@lists.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"Nori\, Sekhar" <nsekhar@...com>,
	"Hebbar\, Gururaja" <gururaja.hebbar@...com>,
	"Bedia\, Vaibhav" <vaibhav.bedia@...com>,
	Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH v4 05/11] pwm: pwm-tiecap: pinctrl support

>>>>> "Thierry" == Thierry Reding <thierry.reding@...onic-design.de> writes:

Hi,

 Thierry> Everybody seems to be doing it with a warning, so I guess
 Thierry> that's fine for now. I just find it strange that if you
 Thierry> request the default pin group to be selected when in fact the
 Thierry> hardware doesn't support pinctrl at all you shouldn't be
 Thierry> getting an error either.

There's several different situations:

- Platform without pinctrl support
- Platform with pinctrl support but no pinmux specified in dt for device
  (E.G. pinmux setup in bootloader)
- Pinmux specified in dt
- Some kind of misconfiguration in dt

You could argue that devm_pinctrl_get_select_default() shouldn't return
an error for the first situation, but how should it be able to know the
difference between 2 and 4?

-- 
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/