linux-kernel - Re: [PATCH] serial:ifx6x60:Delete SPI timer when shut down port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1353633909.22077.12.camel@bichao>
Date:	Fri, 23 Nov 2012 09:25:09 +0800
From:	chao bi <chao.bi@...el.com>
To:	Alan Cox <alan@...ux.intel.com>
Cc:	richardx.r.gorby@...el.com, jun.d.chen@...el.com,
	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] serial:ifx6x60:Delete SPI timer when shut down port

On Thu, 2012-11-22 at 11:06 +0000, Alan Cox wrote:
> > --- a/drivers/tty/serial/ifx6x60.c
> > +++ b/drivers/tty/serial/ifx6x60.c
> > @@ -552,7 +552,10 @@ static void ifx_port_shutdown(struct tty_port
> > *port) container_of(port, struct ifx_spi_device, tty_port);
> >  
> >  	mrdy_set_low(ifx_dev);
> > -	clear_bit(IFX_SPI_STATE_TIMER_PENDING, &ifx_dev->flags);
> > +	if (test_and_clear_bit(IFX_SPI_STATE_TIMER_PENDING,
> > +		&ifx_dev->flags)) {
> > +		del_timer(&ifx_dev->spi_timer);
> > +	}
> 
> You don't actually need the test here as far as I can see. Providing a
> timer has been initialised (init_timer) then running del_timer is safe
> even if the timer is not currently queued or has completed.
> 
> Alan

Yes, thanks. I'll update it.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/