linux-kernel - Re: [PATCH] of/address: sparc: Declare of_iomap as an extern function for sparc again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 23 Nov 2012 23:34:20 +0000
From:	Grant Likely <grant.likely@...retlab.ca>
To:	David Miller <davem@...emloft.net>, andreas@...sler.com
CC:	sam@...nborg.org, rob.herring@...xeda.com,
	sparclinux@...r.kernel.org, devicetree-discuss@...ts.ozlabs.org,
	linux-kernel@...r.kernel.org, software@...sler.com,
	stable <stable@...r.kernel.org>
Subject: Re: [PATCH] of/address: sparc: Declare of_iomap as an extern function for sparc again

Cc'ing stable since this should go into previous kernels too.

g.


Grant Likely <grant.likely@...retlab.ca> wrote:

>On Fri, 23 Nov 2012 14:21:10 -0500 (EST), David Miller
><davem@...emloft.net> wrote:
>> From: Andreas Larsson <andreas@...sler.com>
>> Date: Fri, 23 Nov 2012 12:24:09 +0100
>> 
>> > This bug-fix makes sure that of_iomap is defined extern for sparc
>so that the
>> > sparc-specific implementation of_iomap is once again used when
>including
>> > include/linux/of_address.h in a sparc context. OF_GPIO that is now
>available for
>> > sparc relies on this.
>> > 
>> > The bug was inadvertently introduced in a850a75, "of/address: add
>empty static
>> > inlines for !CONFIG_OF", that added a static dummy inline for
>of_iomap when
>> > !CONFIG_OF_ADDRESS. However, CONFIG_OF_ADDRESS is never defined for
>sparc, but
>> > there is a sparc-specific implementation
>/arch/sparc/kernel/of_device_common.c.
>> > 
>> > This fix takes the same approach as 0bce04b that solved the
>equivalent problem
>> > for of_address_to_resource.
>> > 
>> > Signed-off-by: Andreas Larsson <andreas@...sler.com>
>> 
>> Grant, can you possibly merge this to Linus while I'm travelling?
>> That would help me a lot.
>
>Yup, I'm doing it right now.
>
>g.

-- 
Grant Likely, P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/