linux-kernel - Re: [PATCH] regulator: max8925: fix compiler warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121123014135.GC4385@opensource.wolfsonmicro.com>
Date:	Fri, 23 Nov 2012 10:41:36 +0900
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Qing Xu <qingx@...vell.com>
Cc:	lrg@...com, haojian.zhuang@...il.com, cxie4@...vell.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regulator: max8925: fix compiler warnings

On Thu, Nov 22, 2012 at 10:11:06AM +0800, Qing Xu wrote:

> -	int i, regulator_idx;
> +	int i;
> +	int regulator_idx = 0;

This sort of fix is rarely good without some analysis as to why this is
a sensible initialisation to do, just unconditionally initialising may
be masking a real issue in the control flow which the compiler has
identified.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)