linux-kernel - Re: [BUGFIX PATCH] ASoC: fsl: fix miscompilation of snd-soc-imx-pcm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121123020517.GJ4385@opensource.wolfsonmicro.com>
Date:	Fri, 23 Nov 2012 11:05:18 +0900
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Lothar Waßmann <LW@...O-electronics.de>
Cc:	alsa-devel@...a-project.org, Shawn Guo <shawn.guo@...aro.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [BUGFIX PATCH] ASoC: fsl: fix miscompilation of snd-soc-imx-pcm

On Thu, Nov 22, 2012 at 01:31:06PM +0100, Lothar Waßmann wrote:

>  obj-$(CONFIG_SND_SOC_IMX_PCM) += snd-soc-imx-pcm.o
>  snd-soc-imx-pcm-y := imx-pcm.o
> -snd-soc-imx-pcm-$(CONFIG_SND_SOC_IMX_PCM_FIQ) += imx-pcm-fiq.o
> -snd-soc-imx-pcm-$(CONFIG_SND_SOC_IMX_PCM_DMA) += imx-pcm-dma.o
> +ifneq ($(CONFIG_SND_SOC_IMX_PCM_FIQ),)
> +	snd-soc-imx-pcm-objs += imx-pcm-fiq.o
> +endif
> +ifneq ($(CONFIG_SND_SOC_IMX_PCM_DMA),)
> +	snd-soc-imx-pcm-objs += imx-pcm-dma.o
> +endif

What is the actual bug here?  This fix doesn't look obviously right, and
if we do need to move to -objs for some reason then the block ought to
be in the -objs section of the Makefile.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)