linux-kernel - RE: [RFC][PATCH] printk: add boot_quiet param to support deferred printk while booting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5EB3BFCD089AD643B9BB63439F5FD5E9012297F567@SHAASIEXM01.ASIA.ROOT.PRI>
Date:	Fri, 23 Nov 2012 03:24:15 +0000
From:	Barry Song <Barry.Song@....com>
To:	Baruch Siach <baruch@...s.co.il>
CC:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	DL-SHA-WorkGroupLinux <Workgroup.Linux@....com>,
	"linux-pm@...ts.linux-foundation.org" 
	<linux-pm@...ts.linux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: RE: [RFC][PATCH] printk: add boot_quiet param to support deferred
 printk while booting

Hi Baruch,
Thanks!

> -----Original Message-----
> From: Baruch Siach [mailto:baruch@...s.co.il]
> Sent: Friday, November 23, 2012 11:07 AM
> To: Barry Song
> Cc: gregkh@...uxfoundation.org; DL-SHA-WorkGroupLinux;
> linux-pm@...ts.linux-foundation.org; linux-kernel@...r.kernel.org;
> linux-arm-kernel@...ts.infradead.org
> Subject: Re: [RFC][PATCH] printk: add boot_quiet param to support deferred
> printk while booting
> 
> Hi Barry,
> 
> On Fri, Nov 23, 2012 at 10:50:22AM +0800, Barry Song wrote:
> 
> [...]
> 
> > diff --git a/kernel/printk.c b/kernel/printk.c
> > index 2d607f4..0b88d6bf 100644
> > --- a/kernel/printk.c
> > +++ b/kernel/printk.c
> > @@ -250,6 +250,9 @@ static u32 clear_idx;
> >  #define LOG_ALIGN __alignof__(struct log)
> >  #endif
> >  #define __LOG_BUF_LEN (1 << CONFIG_LOG_BUF_SHIFT)
> > +static char __boot_log_buf[__LOG_BUF_LEN] __aligned(LOG_ALIGN);
> 
> Since we do not use this buffer when the system is running, is there a way to
> release it once its content has been written to console?
> 

Definitely yes. at this moment the code is just a RFC to get people's agreement about the idea.

i have a note in my RFC if you didn't miss :-)
" Note: This is only a RFC, after we agree about the idea, i will move the boot_log_buf to __initdata."

> baruch
> 
> > +static int boot_log_len;
> > +
> >  static char __log_buf[__LOG_BUF_LEN] __aligned(LOG_ALIGN);
> >  static char *log_buf = __log_buf;
> >  static u32 log_buf_len = __LOG_BUF_LEN;
> > @@ -1247,6 +1250,16 @@ module_param(ignore_loglevel, bool, S_IRUGO |
> S_IWUSR);
> 

-barry



Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
More information can be found at www.csr.com. Follow CSR on Twitter at http://twitter.com/CSR_PLC and read our blog at www.csr.com/blog