linux-kernel - Re: [PATCH 1/8 v3] DMA: PL330: use prefix in reg names to build under x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJe_ZhcGmeTviV8v8eCMFZTWLnOb24_kVa1TkZF=9oyc6=vA4A@mail.gmail.com>
Date:	Sat, 24 Nov 2012 10:44:36 +0530
From:	Jassi Brar <jaswinder.singh@...aro.org>
To:	Davide Ciminaghi <ciminaghi@...dd.com>
Cc:	viresh.linux@...il.com, giancarlo.asnaghi@...com,
	rajeev-dlh.kumar@...com, linux@....linux.org.uk, nico@...xnic.net,
	vinod.koul@...el.com, linus.walleij@...aro.org, hpa@...or.com,
	linux-kernel@...r.kernel.org, grant.likely@...retlab.ca,
	wim@...ana.be, mingo@...hat.com, ben-linux@...ff.org, djbw@...com,
	tglx@...utronix.de, cjb@...top.org, rubini@...dd.com,
	linux-arm-kernel@...ts.infradead.org, davidb@...eaurora.org
Subject: Re: [PATCH 1/8 v3] DMA: PL330: use prefix in reg names to build under x86

On 24 November 2012 06:23, Davide Ciminaghi <ciminaghi@...dd.com> wrote:
> From: Alessandro Rubini <rubini@...dd.com>
>
> This driver would not compile if ARM_AMBA is selected under x86,
> because "CS" and "DS" are already defined there.  But AMBA
> is used in the x86 world by a PCI-to-AMBA bridge, to be submitted.
>
> The patch just adds the "PL330_" prefix to all register and bit fields,
> so it can be built by randomconfig after ARM_AMBA appears within x86.

Prefixing only CS and DS should be do the job.
Why do we have to make every symbol noisy with PL330_ ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/