linux-kernel - Re: [patch 4/8] mem-hotplug selftests: print failure status instead of cause make error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOJsxLFxhDYPmqy2s8WYtpPbhAqB3nAzFoyEGwmypfUC54ju-Q@mail.gmail.com>
Date:	Sat, 24 Nov 2012 11:42:35 +0200
From:	Pekka Enberg <penberg@...nel.org>
To:	dyoung@...hat.com
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [patch 4/8] mem-hotplug selftests: print failure status instead
 of cause make error

On Sat, Nov 24, 2012 at 10:29 AM,  <dyoung@...hat.com> wrote:
>   bash-4.1$ make -C memory-hotplug run_tests
>   make: Entering directory `/home/dave/git/linux-2.6/tools/testing/selftests/memory-hotplug'
>   ./on-off-test.sh
>   make: execvp: ./on-off-test.sh: Permission denied
>   make: *** [run_tests] Error 127
>   make: Leaving directory `/home/dave/git/linux-2.6/tools/testing/selftests/memory-hotplug'
>
> After applying the patch:
>   bash-4.1$ make -C memory-hotplug run_tests
>   make: Entering directory `/home/dave/git/linux-2.6/tools/testing/selftests/memory-hotplug'
>   /bin/sh: ./on-off-test.sh: Permission denied
>   memory-hotplug selftests: [FAIL]
>   make: Leaving directory `/home/dave/git/linux-2.6/tools/testing/selftests/memory-hotplug'
>
> Signed-off-by: Dave Young <dyoung@...hat.com>

Reviewed-by: Pekka Enberg <penberg@...nel.org>

It'd be good if we could turn off the make produced noise to make the
output look something like this:

   bash-4.1$ make -C memory-hotplug run_tests
   /bin/sh: ./on-off-test.sh: Permission denied
   memory-hotplug selftests: [FAIL]

> ---
>  tools/testing/selftests/memory-hotplug/Makefile |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-2.6.orig/tools/testing/selftests/memory-hotplug/Makefile      2012-11-23 22:37:04.869057759 +0800
> +++ linux-2.6/tools/testing/selftests/memory-hotplug/Makefile   2012-11-23 22:38:43.148525333 +0800
> @@ -1,6 +1,6 @@
>  all:
>
>  run_tests:
> -       ./on-off-test.sh
> +       @./on-off-test.sh || echo "memory-hotplug selftests: [FAIL]"
>
>  clean:
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/