linux-kernel - Re: [PATCH 1/8 v3] DMA: PL330: use prefix in reg names to build under x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJe_Zhck-vLQEHisE2ORbygmhA=7fcStuvOo2f4rvuCa1tAhEg@mail.gmail.com>
Date:	Sat, 24 Nov 2012 16:35:37 +0530
From:	Jassi Brar <jaswinder.singh@...aro.org>
To:	Alessandro Rubini <rubini@...dd.com>
Cc:	ciminaghi@...dd.com, viresh.linux@...il.com,
	giancarlo.asnaghi@...com, rajeev-dlh.kumar@...com,
	linux@....linux.org.uk, nico@...xnic.net, vinod.koul@...el.com,
	linus.walleij@...aro.org, hpa@...or.com,
	linux-kernel@...r.kernel.org, grant.likely@...retlab.ca,
	wim@...ana.be, mingo@...hat.com, ben-linux@...ff.org, djbw@...com,
	tglx@...utronix.de, cjb@...top.org,
	linux-arm-kernel@...ts.infradead.org, davidb@...eaurora.org
Subject: Re: [PATCH 1/8 v3] DMA: PL330: use prefix in reg names to build under x86

On 24 November 2012 12:33, Alessandro Rubini <rubini@...dd.com> wrote:
> My patch:
>>> This driver would not compile if ARM_AMBA is selected under x86,
>>> because "CS" and "DS" are already defined there.  But AMBA
>>> is used in the x86 world by a PCI-to-AMBA bridge, to be submitted.
>>>
>>> The patch just adds the "PL330_" prefix to all register and bit fields,
>>> so it can be built by randomconfig after ARM_AMBA appears within x86.
>
> Jassy Brar:
>> Prefixing only CS and DS should be do the job.
>> Why do we have to make every symbol noisy with PL330_ ?
>
> For internal consistency. I attacked this problem in July. This is
> what you wrote:
>
>    I fully agree with your point and IIRC I always add some prefix to
>    definitions in header files.
>    Private defines in a .c file, without redundant prefixes, sounded like
>    safe to me at the time, but perhaps I was wrong.
>
>    (references: http://lkml.org/lkml/2012/7/1/56)
>
> So I made the changes overall.  I dislike needless long patches, but
> picking symbols to work around the conflict of the day while
> introducing inconsistent naming doesn't look good to me.
>
Sorry if I gave the wrong impression. I didn't agree (and IIRC nobody
suggested) we prefix _every_ symbol in the driver now. Just CS, DS, ES
and maybe SA, DA, CC too for some consistency. IOW, only regs, not
bit-fields.

regards.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/