linux-kernel - Re: kmemleak report on isp1763 and sierra MC8705

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1353853489.4266.1.camel@deadeye.wl.decadent.org.uk>
Date:	Sun, 25 Nov 2012 15:24:49 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Richard Retanubun <richardretanubun@...gedcom.com>,
	Johan Hovold <jhovold@...il.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Alan Stern <stern@...land.harvard.edu>,
	Lennart Sorensen <lsorense@...lub.uwaterloo.ca>,
	Tang Nguyen <TangNguyen@...gedcom.com>,
	linux-usb mailing list <linux-usb@...r.kernel.org>,
	stable@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: kmemleak report on isp1763 and sierra MC8705

On Tue, 2012-11-20 at 17:15 -0800, Greg Kroah-Hartman wrote:
> On Wed, Nov 14, 2012 at 06:52:18PM +0100, Johan Hovold wrote:
> > On Wed, Nov 14, 2012 at 12:12:01PM -0500, Richard Retanubun wrote:
> > > On 10/11/12 09:30 AM, Johan Hovold wrote:
> > > Hi Johan,
> > > 
> > > > There was a reference-count fix for the probe error path that went in to
> > > > v3.5. Haven't read all the details on how you trigger your leak, but at
> > > > the face of it, it could be related.
> > > >
> > > > Have a look at 0658a3366db7e27fa ("usb: use usb_serial_put in
> > > > usb_serial_probe errors). If related, you should be seeing "Ignoring
> > > > blacklisted interface #n" messages when you enable debug (e.g. #define
> > > > DEBUG) in the sierra driver.
> > > 
> > > That was it! Thanks so much for the research.
> > > I can apply it cleanly to 3.0.22 and see usb_release_dev() being
> > > called and thus no more kmemleak.
> > > 
> > > >
> > > > Greg, it seems to me that the fix referred to above should be backported
> > > > to the earlier stable trees either way.
> > > I would vote "yes" for this also.
> > > 
> > > While my setup circumstances may be a corner case, (modem kept
> > > resetting to re-establish PPP connection) it was leaking 1192 bytes
> > > per occurrence.
> > 
> > The leak affects every failed probe, for example due to blacklisted
> > interfaces which is quite common, so commit 0658a3366db7 ("usb: use
> > usb_serial_put in usb_serial_probe errors) should be backported to the
> > <= 3.4 stable trees.
> 
> Thanks, now applied.

Also queued up for 3.2.

Ben.

-- 
Ben Hutchings
Never attribute to conspiracy what can adequately be explained by stupidity.

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)