linux-kernel - Re: [PATCH 3/5] Input: bu21013_ts - Add support for Device Tree booting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121126093124.GA13792@core.coreip.homeip.net>
Date:	Mon, 26 Nov 2012 01:31:24 -0800
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org
Subject: Re: [PATCH 3/5] Input: bu21013_ts - Add support for Device Tree
 booting

On Mon, Nov 26, 2012 at 09:07:36AM +0000, Lee Jones wrote:
> On Fri, 23 Nov 2012, Dmitry Torokhov wrote:
> 
> > On Fri, Nov 23, 2012 at 03:52:58PM +0000, Lee Jones wrote:
> > > On Wed, 14 Nov 2012, Lee Jones wrote:
> > > 
> > > > Now we can register the BU21013_ts touch screen when booting with
> > > > Device Tree enabled. Here we parse all the necessary components
> > > > previously expected to be passed from platform data.
> > > > 
> > > > Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
> > > > Cc: linux-input@...r.kernel.org
> > > > Acked-by: Arnd Bergmann <arnd@...db.de>
> > > > Acked-by: Linus Walleij <linus.walleij@...aro.org>
> > > > Signed-off-by: Lee Jones <lee.jones@...aro.org>
> > > > ---
> > > >  drivers/input/touchscreen/bu21013_ts.c |   39 ++++++++++++++++++++++++++++----
> > > >  1 file changed, 35 insertions(+), 4 deletions(-)
> > > > 
> > > > diff --git a/drivers/input/touchscreen/bu21013_ts.c b/drivers/input/touchscreen/bu21013_ts.c
> > > > index 5d8fc75..afef874 100644
> > > > --- a/drivers/input/touchscreen/bu21013_ts.c
> > > > +++ b/drivers/input/touchscreen/bu21013_ts.c
> > > > @@ -15,6 +15,8 @@
> > > >  #include <linux/regulator/consumer.h>
> > > >  #include <linux/module.h>
> > > >  #include <linux/gpio.h>
> > > > +#include <linux/of.h>
> > > > +#include <linux/of_gpio.h>
> > > >  
> > > >  /* Reference tracking for multiple displays. */
> > > >  static int bu21013_devices = 0;
> > > > @@ -487,13 +489,33 @@ static void bu21013_free_irq(struct bu21013_ts_data *bu21013_data)
> > > >   * This function used to initializes the i2c-client touchscreen
> > > >   * driver and returns integer.
> > > >   */
> > > > +static void __devinit bu21013_of_probe(struct device_node *np,
> > > > +				struct bu21013_platform_device *pdata)
> > > > +{
> > > > +	pdata->y_flip = pdata->x_flip = false;
> > > > +
> > > > +	if (of_get_property(np, "rohm,flip-x", NULL))
> > > > +		pdata->x_flip = true;
> > 
> > 	pdata->x_flip = of_property_read_bool(np, "rohm,flip-x");
> > 
> > ?
> 
> Yes, we can do this now it exists.
> 
> > Can I also get patch documenting the DT properties?
> 
> Sure. As a follow-up? I'll resubmit this first, right away.

No preference but I am going to fold documentation with the patch
implementing DT support anyway.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/