linux-kernel - Re: [PATCH 1/2] ASoC: davinci-mcasp: Add pinctrl support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121126114511.GE9411@opensource.wolfsonmicro.com>
Date:	Mon, 26 Nov 2012 11:45:11 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	"Hebbar, Gururaja" <gururaja.hebbar@...com>
Cc:	alsa-devel@...a-project.org,
	davinci-linux-open-source@...ux.davincidsp.com,
	linux-arm-kernel@...ts.infradead.org, tony@...mide.com, lrg@...com,
	perex@...ex.cz, nsekhar@...com, sudhakar.raj@...com,
	linux-kernel@...r.kernel.org, devicetree-discuss@...ts.ozlabs.org,
	linux-doc@...r.kernel.org, rob@...dley.net
Subject: Re: [PATCH 1/2] ASoC: davinci-mcasp: Add pinctrl support

On Thu, Nov 22, 2012 at 09:34:58AM +0530, Hebbar, Gururaja wrote:

> +	pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
> +	if (IS_ERR(pinctrl))
> +		dev_warn(&pdev->dev,
> +			"pins are not configured from the driver\n");

Since the driver is happy to continue without the pins why is it
bothering requesting them in the first place?  In other words, this
should be a hard error.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)