linux-kernel - Re: [PATCH] watchdog: da9052: Fix invalid free of devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM=Q2csrtLOCvQpkSfLfE3teCYU1GUzdVaBpuWwocLy2j-9Wuw@mail.gmail.com>
Date:	Mon, 26 Nov 2012 18:31:56 +0530
From:	Shubhrajyoti Datta <omaplinuxkernel@...il.com>
To:	Tushar Behera <tushar.behera@...aro.org>
Cc:	linux-kernel@...r.kernel.org, linux-watchdog@...r.kernel.org,
	wim@...ana.be, patches@...aro.org, Anthony.Olech@...semi.com
Subject: Re: [PATCH] watchdog: da9052: Fix invalid free of devm_ allocated data

On Thu, Nov 22, 2012 at 10:13 AM, Tushar Behera
<tushar.behera@...aro.org> wrote:
> It is not required to free devm_ allocated data. Since kref_put
> needs a valid release function, da9052_wdt_release_resources()
> is not deleted.
>
> Fixes following warning.
> drivers/watchdog/da9052_wdt.c:59:1-6: WARNING: invalid free of
> devm_ allocated data
>
> Signed-off-by: Tushar Behera <tushar.behera@...aro.org>
> ---
>  drivers/watchdog/da9052_wdt.c |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/watchdog/da9052_wdt.c b/drivers/watchdog/da9052_wdt.c
> index f7abbae..20071de 100644
> --- a/drivers/watchdog/da9052_wdt.c
> +++ b/drivers/watchdog/da9052_wdt.c
> @@ -53,10 +53,6 @@ static const struct {
>
>  static void da9052_wdt_release_resources(struct kref *r)
>  {
> -       struct da9052_wdt_data *driver_data =
> -               container_of(r, struct da9052_wdt_data, kref);
> -
> -       kfree(driver_data);

However now the function will be empty right?


>  }
>
>  static int da9052_wdt_set_timeout(struct watchdog_device *wdt_dev,
> --
> 1.7.4.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/