linux-kernel - Re: [PATCH] No need to call irq_domain_legacy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20121126201739.13F213E09C2@localhost>
Date:	Mon, 26 Nov 2012 20:17:39 +0000
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Mike Qiu <qiudayu@...ux.vnet.ibm.com>, linux-kernel@...r.kernel.org
Cc:	tglx@...utronix.de, benh@...nel.crashing.org,
	Mike Qiu <qiudayu@...ux.vnet.ibm.com>
Subject: Re: [PATCH] No need to call irq_domain_legacy_revmap() for twice

On Mon, 24 Sep 2012 17:37:55 +0800, Mike Qiu <qiudayu@...ux.vnet.ibm.com> wrote:
> Function irq_create_mapping() calls irq_find_mapping(). The later
> function has checked if the indicated IRQ domain has hw IRQ mapped to
> virtual IRQ through legacy mode or not and return the value of the
> legacy irq number by call irq_domain_legacy_revmap(). We needn't
> to call irq_domain_legacy_revmap() to do same check in
> irq_create_mapping() again.
> 
> The patch removes the duplicate call.
> 
> Signed-off-by: Mike Qiu <qiudayu@...ux.vnet.ibm.com>
> ---
>  kernel/irq/irqdomain.c |    7 +++++--
>  1 files changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
> index 49a7772..286d672 100644
> --- a/kernel/irq/irqdomain.c
> +++ b/kernel/irq/irqdomain.c
> @@ -547,9 +547,12 @@ unsigned int irq_create_mapping(struct irq_domain *domain,
>  		return virq;
>  	}
>  
> -	/* Get a virtual interrupt number */
> +	/*
> +	 * For IRQ domain with type of IRQ_DOMAIN_MAP_LEGACY, we needn't
> +	 * create the IRQ mapping for non-existing one, so just return 0.
> +	 */
>  	if (domain->revmap_type == IRQ_DOMAIN_MAP_LEGACY)
> -		return irq_domain_legacy_revmap(domain, hwirq);
> +		return 0;

But it does need to return the virq assigned to the hwirq. That is why
it has to call the revmap function.

g.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/