linux-kernel - Re: [PATCHv3] tty: Added a CONFIG_TTY option to allow removal of TTY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121126233824.GA8868@kroah.com>
Date:	Mon, 26 Nov 2012 15:38:24 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Joe Millenbach <jmillenbach@...il.com>
Cc:	Alan Cox <alan@...ux.intel.com>, Jiri Slaby <jirislaby@...il.com>,
	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
	Josh Triplett <josh@...htriplett.org>
Subject: Re: [PATCHv3] tty: Added a CONFIG_TTY option to allow removal of TTY

On Thu, Nov 15, 2012 at 06:30:35PM -0800, Joe Millenbach wrote:
> The option allows you to remove TTY and compile without errors. This
> saves space on systems that won't support TTY interfaces anyway.
> bloat-o-meter output is below.
> 
> The bulk of this patch consists of Kconfig changes adding "depends on
> TTY" to various serial devices and similar drivers that require the TTY
> layer.  Ideally, these dependencies would occur on a common intermediate
> symbol such as SERIO, but most drivers "select SERIO" rather than
> "depends on SERIO", and "select" does not respect dependencies.
> 
> bloat-o-meter output filtered to not show removed entries with awk
> '$3 != "-"' as the list was very long.
> 
> add/remove: 0/385 grow/shrink: 2/18 up/down: 14/-54016 (-54002)
> function                                     old     new   delta
> chr_dev_init                                 193     205     +12
> selinux_setprocattr                         1167    1169      +2
> static.__warned                              557     556      -1
> start_kernel                                 840     835      -5
> proc_root_init                               167     162      -5
> unregister_console                           165     157      -8
> sys_setsid                                   213     205      -8
> sys_vhangup                                   37      21     -16
> daemonize                                    689     673     -16
> t_stop                                        72      54     -18
> t_next                                       129     108     -21
> static.do_acct_process                       838     806     -32
> release_task                                1157    1125     -32
> do_exit                                     2325    2288     -37
> t_start                                      269     221     -48
> static.__func__                            18289   18219     -70
> do_task_stat                                2962    2892     -70
> flush_unauthorized_files                     740     614    -126
> static._rs                                  1440    1280    -160
> static.__key                                8560    8384    -176
> 
> Signed-off-by: Joe Millenbach <jmillenbach@...il.com>
> Reviewed-by: Josh Triplett <josh@...htriplett.org>

This is a nice idea, but I feel it's a bit too late in the 3.8 merge
window cycle for me to add this to linux-next at this point in time.

Can you rediff this once 3.8-rc1 is out and send it to me then?  That
way we can get a lot more testing in linux-next in order to make sure
it's ready for 3.9?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/