linux-kernel - Re: [PATCH] ioat: remove chanerr mask setting for IOAT v3.x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAA9_cmfYpa+ByFDJNwqxsj+e_3xrZD-=EP-NGQmWuWjgc7ZRtw@mail.gmail.com>
Date:	Mon, 26 Nov 2012 20:56:06 -0800
From:	Dan Williams <djbw@...com>
To:	Dave Jiang <dave.jiang@...el.com>
Cc:	vinod.koul@...el.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ioat: remove chanerr mask setting for IOAT v3.x

On Fri, Nov 16, 2012 at 3:26 PM, Dave Jiang <dave.jiang@...el.com> wrote:
> The CHANERRMSK_INT register should be 0. The existing code set a value
> for a workaround to address a pre-silicon bug on the Intel 5520 IO hub that
> has been fixed when the hardware was released. There is no need for this
> code.
>
> Signed-off-by: Dave Jiang <dave.jiang@...el.com>
> ---
>
>  drivers/dma/ioat/dma_v3.c |    8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/dma/ioat/dma_v3.c b/drivers/dma/ioat/dma_v3.c
> index f7f1dc6..60c15c4 100644
> --- a/drivers/dma/ioat/dma_v3.c
> +++ b/drivers/dma/ioat/dma_v3.c
> @@ -1126,12 +1126,8 @@ static int ioat3_reset_hw(struct ioat_chan_common *chan)
>         chanerr = readl(chan->reg_base + IOAT_CHANERR_OFFSET);
>         writel(chanerr, chan->reg_base + IOAT_CHANERR_OFFSET);
>
> -       /* -= IOAT ver.3 workarounds =- */
> -       /* Write CHANERRMSK_INT with 3E07h to mask out the errors
> -        * that can cause stability issues for IOAT ver.3, and clear any
> -        * pending errors
> -        */
> -       pci_write_config_dword(pdev, IOAT_PCI_CHANERRMASK_INT_OFFSET, 0x3e07);
> +       /* clearn CHANERRMASK_INT and clear any pending errors */
> +       pci_write_config_dword(pdev, IOAT_PCI_CHANERRMASK_INT_OFFSET, 0);

Can we get rid of this write / register access altogether?  Then the
driver will load on systems where extended pci configuration space is
not available.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/