linux-kernel - Re: [PATCH 1/2] ASoC: davinci-mcasp: Add pinctrl support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87y5hn1tey.fsf@dell.be.48ers.dk>
Date:	Mon, 26 Nov 2012 21:55:33 -0800
From:	Peter Korsgaard <jacmet@...site.dk>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	"Hebbar\, Gururaja" <gururaja.hebbar@...com>,
	alsa-devel@...a-project.org, sudhakar.raj@...com,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	devicetree-discuss@...ts.ozlabs.org, nsekhar@...com,
	davinci-linux-open-source@...ux.davincidsp.com, perex@...ex.cz,
	lrg@...com, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/2] ASoC: davinci-mcasp: Add pinctrl support

>>>>> "Mark" == Mark Brown <broonie@...nsource.wolfsonmicro.com> writes:

Hi,

 Mark> On Thu, Nov 22, 2012 at 09:34:58AM +0530, Hebbar, Gururaja wrote:
 >> +	pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
 >> +	if (IS_ERR(pinctrl))
 >> +		dev_warn(&pdev->dev,
 >> +			"pins are not configured from the driver\n");

 Mark> Since the driver is happy to continue without the pins why is it
 Mark> bothering requesting them in the first place?  In other words, this
 Mark> should be a hard error.

Sorry, I disagree. As was discussed recently, there's several reasons
why the pinctrl call might fail, and not all are fatal (E.G. pinmux
already setup by bootloader):

http://article.gmane.org/gmane.linux.kernel/1399756

-- 
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/