linux-kernel - Re: [PATCH 1/5] Input: bu21013_ts - Request a regulator that actually exists

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121127090512.GE7897@gmail.com>
Date:	Tue, 27 Nov 2012 09:05:12 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org
Subject: Re: [PATCH 1/5] Input: bu21013_ts - Request a regulator that
 actually exists

On Mon, 26 Nov 2012, Dmitry Torokhov wrote:

> On Mon, Nov 26, 2012 at 12:16:18PM +0000, Lee Jones wrote:
> > On Wed, 14 Nov 2012, Lee Jones wrote:
> > 
> > > Currently the BU21013 Touch Screen driver requests a regulator by the
> > > name of 'V-TOUCH', which doesn't exist anywhere in the kernel. The
> > > correct name, as referenced in platform regulator code is 'avdd'. Here,
> > > when we request a regulator, we use the correct name instead.
> > > 
> > > Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
> > > Cc: linux-input@...r.kernel.org
> > > Acked-by: Arnd Bergmann <arnd@...db.de>
> > > Acked-by: Linus Walleij <linus.walleij@...aro.org>
> > > Signed-off-by: Lee Jones <lee.jones@...aro.org>
> > > ---
> > >  drivers/input/touchscreen/bu21013_ts.c |    2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/input/touchscreen/bu21013_ts.c b/drivers/input/touchscreen/bu21013_ts.c
> > > index 5c487d2..2fae682 100644
> > > --- a/drivers/input/touchscreen/bu21013_ts.c
> > > +++ b/drivers/input/touchscreen/bu21013_ts.c
> > > @@ -461,7 +461,7 @@ static int __devinit bu21013_probe(struct i2c_client *client,
> > >  	bu21013_data->chip = pdata;
> > >  	bu21013_data->client = client;
> > >  
> > > -	bu21013_data->regulator = regulator_get(&client->dev, "V-TOUCH");
> > > +	bu21013_data->regulator = regulator_get(&client->dev, "avdd");
> > >  	if (IS_ERR(bu21013_data->regulator)) {
> > >  		dev_err(&client->dev, "regulator_get failed\n");
> > >  		error = PTR_ERR(bu21013_data->regulator);
> > > -- 
> > > 1.7.9.5
> > 
> > Did you see this one also Dmitry?
> 
> Yes, I have it, I am waiting for the other 2 patches in series to
> settle.

This patch is unrelated to the others and fixes a bug. Would you
be kind enough to take it in right away please?

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/