linux-kernel - Re: [RFC PATCH 06/06] input/rmi4: F11

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAN+gG=GikXu-bJq7McYZedCy=8SgPbsktvNXzSRh04PVZg0yDQ@mail.gmail.com>
Date:	Tue, 27 Nov 2012 14:01:38 +0100
From:	Benjamin Tissoires <benjamin.tissoires@...il.com>
To:	Christopher Heiny <cheiny@...aptics.com>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Jean Delvare <khali@...ux-fr.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Linux Input <linux-input@...r.kernel.org>,
	Allie Xiong <axiong@...aptics.com>,
	Vivian Ly <vly@...aptics.com>,
	Daniel Rosenberg <daniel.rosenberg@...aptics.com>,
	Alexandra Chin <alexandra.chin@...synaptics.com>,
	Joerie de Gram <j.de.gram@...il.com>,
	Wolfram Sang <w.sang@...gutronix.de>,
	Mathieu Poirier <mathieu.poirier@...aro.org>,
	Linus Walleij <linus.walleij@...ricsson.com>
Subject: Re: [RFC PATCH 06/06] input/rmi4: F11 - 2D touch interface

Hi Christopher,

I did not made a full review, but at least, there is a problem in your
rmi_f11_finger_handler function:

On Sat, Nov 17, 2012 at 4:58 AM, Christopher Heiny <cheiny@...aptics.com> wrote:
> rmi_f11.c is a driver for 2D touch sensors using the RMI4 protocol.  It supports
> both touchscreen and touchpad input, in both absolute and relative formats.
> Support for Type-B multitouch is the default, Type-A support is included for
> certain legacy sensors.
>
>
> Signed-off-by: Christopher Heiny <cheiny@...aptics.com>
>
> To: Henrik Rydberg <rydberg@...omail.se>
> Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
> Cc: Linus Walleij <linus.walleij@...ricsson.com>
> Cc: Naveen Kumar Gaddipati <naveen.gaddipati@...ricsson.com>
> Cc: Joeri de Gram <j.de.gram@...il.com>
>
> ---
>
>  drivers/input/rmi4/rmi_f11.c | 2813 ++++++++++++++++++++++++++++++++++++++++++
>  1 files changed, 2813 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4/rmi_f11.c
> new file mode 100644
> index 0000000..b9a84bc
> --- /dev/null
> +++ b/drivers/input/rmi4/rmi_f11.c
[snipped]
> +static void rmi_f11_finger_handler(struct f11_data *f11,
> +                                  struct f11_2d_sensor *sensor)
> +{
> +       const u8 *f_state = sensor->data.f_state;
> +       u8 finger_state;
> +       u8 finger_pressed_count;
> +       u8 i;
> +
> +       for (i = 0, finger_pressed_count = 0; i < sensor->nbr_fingers; i++) {
> +               /* Possible of having 4 fingers per f_statet register */
> +               finger_state = (f_state[i / 4] >> (2 * (i % 4))) &
> +                                       FINGER_STATE_MASK;
> +               if (finger_state == F11_RESERVED) {
> +                       pr_err("%s: Invalid finger state[%d]:0x%02x.", __func__,
> +                                       i, finger_state);
> +                       continue;
> +               } else if ((finger_state == F11_PRESENT) ||
> +                               (finger_state == F11_INACCURATE)) {
> +                       finger_pressed_count++;
> +               }
> +
> +               if (sensor->data.abs_pos)
> +                       rmi_f11_abs_pos_report(f11, sensor, finger_state, i);
> +
> +               if (sensor->data.rel_pos)
> +                       rmi_f11_rel_pos_report(sensor, i);
> +       }
> +       input_mt_sync(sensor->input);

This should be "input_mt_sync_frame(sensor->input);"
otherwise, the synaptics xorg driver won't handle the touchpad correctly.

Cheers,
Benjamin

> +       input_sync(sensor->input);
> +}
> +
[snipped]
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/